Implemented Mods from Heliosphere not appending Version, Variant, and Author ID to Mod Folders

This suggestion was implemented.
Metaknight

Metaknight

Creator
A valid mod already requires hs- appended to the front of a folder and a valid heliosphere.json inside containing three IDs for identification and is read in/out during download/fetching. This blob of IDs ends up making it tremendously long (+/-65~ extra characters) just for the folder name. This additional length can cause problems such as a version of a Mod being uploaded to HS vs XMA can end up bricking because of the extra size depending on how far buried the folder is + mod name itself. For the user facing experience, it causes much more clutter and chaos having the giant blob of characters at the end given how bad searching can be already.

Is it possible to not have HS append the previously mentioned IDs to the folder name for the mod and instead read/check from the heliosphere.json if the relevant prefix (hs-) is found?
Is appending the Version, Variant, and Author ID necessary to the folder itself, if so may I ask why when each folder comes with it's own heliosphere.json?
 
Upvote 0 Downvote
This suggestion has been implemented. Votes are no longer accepted.
Metaknight said:
Is appending the Version, Variant, and Author ID necessary to the folder itself, if so may I ask why when each folder comes with it's own heliosphere.json?
Click to expand...
The honest answer is that I don't remember exactly. The code is so old at this point that I have forgotten what younger me was thinking. I know I tried to remove them once before, and it caused a bunch of issues.

Removing the IDs is not super high in my priorities, but I will be investigating it again sometime soon. Also just as fair notice, it's not even possible until a Penumbra update fixes a bug I encountered when trying to shorten the ID lengths in the folder name, anyway.

Edit to add: the presence of the correct folder name structure is used as evidence that a mod was installed via plugin, currently, so that would have to change were I to remove the IDs. So I guess it is technically used for something. That would be easy to change, though.
 
That's good to hear it could be changed, understandable if it's lower priority of course.

Huh, I wasn't really aware of some bug going on regarding naming in penumbra, is it not fixed in testing? Mostly as I can't see it being referenced or it being known atm.
 
Otter and I tracked it down on 22 Jan. Fixed in testing then.
 
This is now (sort of) done in 4.0.0. A version and short variant ID are appended, both of which are needed to (easily) avoid expensive FS hits. Combined with the hs- prefix, this should be between 12 and 14 extra characters. Is that acceptable?
 
You must log in or register to reply here.
Back
Top